How much better is the XBoneX over the XBone? Does it fix the problem where it takes like half an hour to install a game?
Unless you have a 4K TV there's little reason to get a PS4 Pro. Some games don't even deliver supersampling if the console is set to output 1080p. PS4 Pro might be worth picking up some day when they are cheap for legacy PS4 support, depending on how PS4 backward compatibility is implemented in the PS5.
For now, the Xbox One X is much more worth the upgrade, even on a 1080p screen. The gulf between the base Xbox One and the X is much wider than that of the PS4 and the Pro. The standard PS4 is already a decent 1080p machine for most games.
When you do get a 4K TV, make sure you get one with HDR. I think you'd regret spending all the money on a new TV and not having that since it makes a pretty big difference. Also, I don't a 4K TV is really worth getting at this point unless you want to play games on it. There's just not enough good content for them yet outside of video games, imo.